Update display.php#39
Open
orwah wants to merge 1 commit into
Open
Conversation
i guess this 2 lines must be commented by default for viewing Buttons images instead of using css button style (as default)
Contributor
|
CSS buttons are a safer choice because they will work as soon as the text is translated into local language. Images, on the other hand, would have to be created, which takes more time and higher level of skills. |
Contributor
|
What do you think? |
Contributor
Author
|
it's true . the only problem is that Users will take along time to specify the files for changing this back to Images. and for adjust the Buttons properties in css. I think, it would be good to have this as an option in Preferences . |
mambax7
added a commit
to mambax7/newbb
that referenced
this pull request
Feb 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i guess
this 2 lines must be commented by default
for viewing Buttons images instead of using css button style (as default)